Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement IPFS (AIP11) #2537

Merged
merged 15 commits into from
May 7, 2019
Merged

feat: Implement IPFS (AIP11) #2537

merged 15 commits into from
May 7, 2019

Conversation

air1one
Copy link
Contributor

@air1one air1one commented May 7, 2019

Summary

Enable handling of IPFS transactions.

Resolves #1591.

What kind of change does this PR introduce?

  • New feature

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
    • All tests are passing
    • All benchmarks are passing without any major regressions
    • Sync from 0 works on mainnet
    • Sync from 0 works on devnet
    • Starting a new network and forging on it work
    • Explorer is fully functional
    • Wallets are fully functional
  • No

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@ghost ghost added Complexity: High labels May 7, 2019
@faustbrian faustbrian changed the title feat: enabling ipfs transactions feat: Implement IPFS (AIP11) May 7, 2019
@ghost
Copy link

ghost commented May 7, 2019

The ci/circleci: test-node11-integration-1 job is failing as of 379c2472455151c584122d4a23c84b588d202d82. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@spkjp spkjp marked this pull request as ready for review May 7, 2019 15:30
@codecov-io
Copy link

Codecov Report

Merging #2537 into develop will increase coverage by 0.18%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2537      +/-   ##
===========================================
+ Coverage    67.17%   67.35%   +0.18%     
===========================================
  Files          399      400       +1     
  Lines         8767     8805      +38     
  Branches       415      454      +39     
===========================================
+ Hits          5889     5931      +42     
+ Misses        2824     2818       -6     
- Partials        54       56       +2
Impacted Files Coverage Δ
packages/crypto/src/transactions/types/schemas.ts 100% <ø> (ø) ⬆️
...pto/src/transactions/builders/transactions/ipfs.ts 100% <ø> (+28%) ⬆️
...s/core-database-postgres/src/integrity-verifier.ts 5.26% <0%> (-0.38%) ⬇️
packages/crypto/src/transactions/types/ipfs.ts 100% <100%> (+53.33%) ⬆️
packages/core-state/src/wallets/wallet.ts 88% <100%> (+0.16%) ⬆️
packages/crypto/src/transactions/deserializer.ts 90.27% <100%> (-0.14%) ⬇️
packages/core-transactions/src/errors.ts 82.35% <50%> (-1.33%) ⬇️
packages/core-tester-cli/src/signer.ts 87.5% <66.66%> (-2.98%) ⬇️
packages/core-tester-cli/src/commands/send/ipfs.ts 70% <70%> (ø)
packages/core-transactions/src/handlers/ipfs.ts 93.75% <88.88%> (+36.6%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dac85a...92496d0. Read the comment docs.

@spkjp spkjp merged commit 2d78da0 into develop May 7, 2019
@ghost ghost deleted the feat/ipfs branch May 7, 2019 16:13
@ghost ghost removed the Status: In Progress label May 7, 2019
vasild added a commit that referenced this pull request May 8, 2019
…legate-resignation

* ArkEcosystem/core/develop:
  chore(deps): update and remove unused dependencies (#2546)
  release: 2.4.0-next.2 (#2545)
  feat(core-wallet-api): initial implementation (#2544)
  fix(core): use the --env flag to start testnet via CLI (#2543)
  release: 2.4.0-next.1 (#2541)
  refactor(core-database-postgres): transaction type agnostic wallet bootstrap (#2539)
  release: 2.4.0-next.0 (#2540)
  refactor(core): let the process manager extend @faustbrian/foreman (#2536)
  feat: Implement IPFS (AIP11) (#2537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants