fix(core-blockchain): only shift milestoneHeights[] if at that height (…

…#2904) The previous code would remove entires from milestoneHeights[] even if no milestone is hit (due to e.g. "currentTransactionsCount >= 150" being true).
ArkEcosystem · Sep 4, 2019 · 56ff979 · 56ff979
1 parent 33d8ba7
commit 56ff979
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/packages/core-blockchain/src/blockchain.ts b/packages/core-blockchain/src/blockchain.ts
@@ -273,7 +273,9 @@ export class Blockchain implements blockchain.IBlockchain {
                 this.queue.push({ blocks: currentBlocksChunk });
                 currentBlocksChunk = [];
                 currentTransactionsCount = 0;
-                milestoneHeights.shift();
+                if (nextMilestone) {
+                    milestoneHeights.shift();
+                }
             }
         }
         this.queue.push({ blocks: currentBlocksChunk });