Closed
Conversation
adding tests for the tree component
first pass at bezier curves for connectors
prepending "node-" to each DOM element id keeping the original id in "data-original-id" attribute
fixing up navigation bugs
when tree nodes are (almost) vertically aligned, use a basic svg path line instead of a bezier curve adding hover (mouseover mouseleave) handling on the target window object and corresponding no-op methods to tree setup these methods
Contributor
Author
updateI added better event handling for navigation, as well as mouseover/leave to highlight target cells. |
click handler display node data in the info panel customization performs additional highlighting
looks like a weird race condition
Contributor
Author
|
closing with #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR adds our own tree plotting JS library (I tried many others and they all had their drawbacks).
Approach
The tree library is comprised of two main components/dom element
tree-graphandtree-node, and svg bezier curves connecting these. Leaf nodes are either terminal (orange) or roots of subtrees (blue). The latter handle a dbl-click event to drill down the tree. Use the up-arrow to up the tree.How Has This Been Tested?
The tree lib has been integrated into the cells devtools (chrome) plugin code and tested out in the UI.
Screenshots or console output (if appropriate)
Types of changes
Checklist: