This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
[SKY-8672] removed colon from the list of reserved char validator and app.js res… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ariemeth
requested review from
aolhovskiy,
leehendricks,
schwing and
willyjfarrell
leehendricks
reviewed
Nov 5, 2020
Comment on lines
+30
to
+32
| /* private static final String[] RESERVED_CHARS = { ":", "/", "?", "#", "[", "@", "!", "$", | ||
| "&", "(", ")", "*", "+", ",", ";", "=", | ||
| "]", "[", "\\" };*/ |
There was a problem hiding this comment.
Did you mean to leave the commented block? Same question for keyPressed logic below.
There was a problem hiding this comment.
I did leave it there on purpose, just not sure if we need to or not
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…triction
Jira SKY-8672