Use React new context API #82
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p10ns11y
commented
Apr 7, 2018
| "react-redux": "^5.0.6", | ||
| "react-scripts": "1.0.17", | ||
| "redux": "^3.7.2", | ||
| "redux-i18n": "^1.5.10", | ||
| "redux-i18n": "https://github.com/p10ns11y/redux-i18n#master", |
There was a problem hiding this comment.
TODO: change after merged and version is bumped
p10ns11y
changed the title
|
This would be a valuable change. I am working on a React app using Typescript and type-checking prohibits the use of React's legacy context api, i.e., I'm getting this error:
Supporting the new React context api would make it easier to work with redux-i18n out of the box with Typescript. Are there any plans to merge these changes in? EDIT: The solution was simple. Make .contextTypes a static property of the class you want to subscribe to redux-i18n's context. |
|
Are there any plans to merge this in? React strongly advocates against the use of legacy context |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this work as beta. ie., I need inputs/feedback from the maintainers what to do with tests. Right now I have added only one