android spinner, isLoading and isDisabled as state #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, thank you Álvaro for this component. I added support for android spinner. I changed isLoading to a state param to make the view refreshable. Also added a isDisabled param. These modifications do not impact current implementations because the constructor is setting the states from the props
Collaborator
|
Many thanks @FaridSafi!! The PR looks cool, I'll try to merge it this evening 👍 |
alvaromb
added a commit
that referenced
this pull request
Nov 9, 2015
Android spinner support, added new ``isDisabled`` state.
Collaborator
|
Merged! Will release tomorrow. |
Collaborator
|
I've changed a bit your code before releasing https://github.com/APSL/react-native-button/releases/tag/v2.2.0. You may want to take a look at Props in getInitialState Is an Anti-Pattern to understand why I deleted the state in the constructor function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you Álvaro for this component.
I added support for android spinner.
I changed isLoading to a state param to make the view refreshable. Also added a isDisabled param.
These modifications do not impact current implementations because the constructor is setting the states from the props