Skip to content

Conversation

@ksiomng
Copy link
Collaborator

@ksiomng ksiomng commented Jan 6, 2025

๐Ÿ“• Issue Number

Close #269

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ํŽธ์ง€ ์“ฐ๊ธฐ๋ทฐ ์ด๋ฏธ์ง€ ๋ฏธ๋ฆฌ๋ณด๊ธฐ
  • ํŽธ์ง€ ์“ฐ๊ธฐ๋ทฐ ์ด๋ฏธ์ง€ ํ”„๋ ˆ์ž„
  • ํŒŒ์ผ ์ •๋ฆฌ

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ์ž‘์—…๋œ ๋ทฐ๋ฅผ ์ •๋ฆฌํ•˜๋‹ค๊ฐ€ ๊ทธ๋ƒฅ ๋ชจ๋“ ํŒŒ์ผ์„ ์ •๋ฆฌํ•ด์„œ ํŒŒ์ผ๋ณ€๊ฒฝ์ด ๋งŽ์Šต๋‹ˆ๋‹ค.
  • ์ด๋ฒˆ์— ์ž‘์—…๋œ ๋‚ด์šฉ์€ ContentWriteView ์—์„œ๋งŒ ํ™•์ธํ•˜๋ฉด ๋ ๊ฑฐ๊ฐ™์Šต๋‹ˆ๋‹ค ...
  • ๋””์ž์ธ์ด๋‚˜ ์ฝ”๋“œ ์ž˜๋ชป๋œ ๋ถ€๋ถ„์„ ๋ง์”€ํ•ด์ฃผ์‹œ๋ฉด ์ˆ˜์ •ํ•˜๊ณ  ๋จธ์ง€ํ• ๊ฒŒ์š” !!!



Copy link
Collaborator

@the-hye the-hye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค์šฐ ๋Œ€๊ทœ๋ชจ ๋ณ€๊ฒฝ,, ๋ฐ•์ˆ˜ ์จ•์จ•๐Ÿ‘

@YuleGlycerine
Copy link
Collaborator

์™€์•„์•„์•™ ์ด๊ฑฐ ๋นจ๋ฆฌ ํ…Œํ”Œ ์˜ฌ๋ ค๋ณด๊ณ ์‹ถ๋„ค์š”!! ๋””์ž์ธ ์กฐ์•„์š”!. ๊ทธ๋Ÿฐ๋ฐ.. ๊ทธ๋ฆผ์ž๊ฐ€ ์•ˆ๋“ค์–ด๊ฐ„ ๊ฒƒ์„ ์ง€๊ธˆ ๋ณด์•˜์๋‹ˆ๋‹ค.. ์ผ๋‹จ ๋จธ์ง€ํ•˜๊ตฌ ๊ทธ๋ฆผ์ž๋Š” ์ดํ›„์— ๋„ฃ์„๊นŒ๋‚˜์š”? ์š” ๊ธฐ๋Šฅ ์ž์ฒด๋ฅผ ๋„˜ ๊ธฐ๋‹ค๋ ธ์–ด์š”. ์ด๊ฒƒ๋งŒ ๋ฉ”์ธ์— ํ•ฉ์ณ์„œ ์—…๋ฐ์ดํŠธ ์˜ฌ๋ฆฌ๋Š” ๊ฒƒ๋„ ์ƒ๊ฐํ•ด๋ด„์ง ํ•˜๋„ค์š”..

@ksiomng ksiomng merged commit c7c5ec8 into Develop Jan 7, 2025
1 check passed
@ksiomng ksiomng self-assigned this Jan 27, 2025
@ksiomng ksiomng deleted the Feat/ImportPhoto branch February 10, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[03-04] ๋™๋ด‰๋œ ์‚ฌ์ง„ ๋ฏธ๋ฆฌ๋ณด๊ธฐ

4 participants