Skip to content

feat: add onBundle callback #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aeworxet
Copy link

@aeworxet aeworxet commented Jul 2, 2025

This PR adds functionality, as well as an options object, for the bundle method, which consists of:

  • The onBundle callback.
  • The excludedPathMatcher callback.

Closes #346

@aeworxet
Copy link
Author

aeworxet commented Jul 2, 2025

This functionality mimics the onDereference callback along with the test, which is likely why the test fails: the bundle method should have different test conditions.

@jonluca, could you please advise what the test should be?

auto-merge was automatically disabled July 2, 2025 10:16

Head branch was pushed to by a user without write access

@jonluca jonluca enabled auto-merge (squash) July 2, 2025 20:48
@jonluca
Copy link
Collaborator

jonluca commented Jul 2, 2025

Hello,

The logic looks sound, I think you just need to fix the test comparison. The bundle traversal is stable, right? The tests aren't failing based on platform, so just make sure yarn test returns 100% on your local machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to add onBundle callback?
2 participants