Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzztest clean-ups #2529

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Fuzztest clean-ups #2529

merged 3 commits into from
Jan 3, 2025

Conversation

vrabaud
Copy link
Collaborator

@vrabaud vrabaud commented Dec 23, 2024

  • merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST
  • allow for fuzztest be built from CMake

@vrabaud vrabaud requested a review from wantehchang December 23, 2024 12:42
@vrabaud vrabaud marked this pull request as ready for review December 23, 2024 12:50
Copy link
Collaborator

@wantehchang wantehchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vincent: This is a very incomplete review. I mainly wanted to respond to the discussion on AVIF_FUZZTEST=SYSTEM/LOCAL/OFF.

cmake/Modules/LocalFuzztest.cmake Outdated Show resolved Hide resolved
cmake/Modules/LocalFuzztest.cmake Show resolved Hide resolved
tests/CMakeLists.txt Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
tests/CMakeLists.txt Show resolved Hide resolved
- merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST
- allow for fuzztest be built from CMake
@vrabaud vrabaud merged commit d3388d9 into AOMediaCodec:main Jan 3, 2025
34 checks passed
@vrabaud vrabaud deleted the pre_msan branch January 3, 2025 09:48
# Adds a fuzztest from file TEST_NAME.cc located in the gtest folder. Extra arguments
# are considered as extra source files.
macro(add_avif_fuzztest TEST_NAME)
add_executable(${TEST_NAME} gtest/${TEST_NAME}.cc ${ARGN})
# FuzzTest bundles GoogleTest so no need to link to gtest librairies.
target_link_libraries(${TEST_NAME} PRIVATE avif_fuzztest_helpers aviftest_helpers_internal avif_enable_warnings)
# avif_enable_warnings is not added because it triggers to many warnings in fuzztest.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: to => too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in #2550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants