-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzztest clean-ups #2529
Fuzztest clean-ups #2529
Conversation
vrabaud
commented
Dec 23, 2024
- merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST
- allow for fuzztest be built from CMake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vincent: This is a very incomplete review. I mainly wanted to respond to the discussion on AVIF_FUZZTEST=SYSTEM/LOCAL/OFF
.
- merge AVIF_ENABLE_FUZZTEST and AVIF_LOCAL_FUZZTEST - allow for fuzztest be built from CMake
# Adds a fuzztest from file TEST_NAME.cc located in the gtest folder. Extra arguments | ||
# are considered as extra source files. | ||
macro(add_avif_fuzztest TEST_NAME) | ||
add_executable(${TEST_NAME} gtest/${TEST_NAME}.cc ${ARGN}) | ||
# FuzzTest bundles GoogleTest so no need to link to gtest librairies. | ||
target_link_libraries(${TEST_NAME} PRIVATE avif_fuzztest_helpers aviftest_helpers_internal avif_enable_warnings) | ||
# avif_enable_warnings is not added because it triggers to many warnings in fuzztest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: to => too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #2550