Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn gain maps on in ci-unix-shared-installed.yml #2511

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Turn gain maps on in ci-unix-shared-installed.yml #2511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Turn gain maps on in ci-unix-shared-installed.yml 
The default values for the install fix are taken from:
https://cmake.org/cmake/help/v3.31/command/install.html#signatures
  • Loading branch information
@vrabaud
vrabaud committed Nov 28, 2024
commit 75d37c0a9214a93d4da1428ee0bf94689af62d6c
1 change: 1 addition & 0 deletions .github/workflows/ci-unix-shared-installed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ jobs:
-DAVIF_BUILD_EXAMPLES=ON -DAVIF_BUILD_APPS=ON
-DAVIF_BUILD_TESTS=ON -DAVIF_ENABLE_GTEST=ON -DAVIF_GTEST=LOCAL
-DAVIF_BUILD_GDK_PIXBUF=ON ${{ env.CMAKE_AVIF_FLAGS }}
-DAVIF_ENABLE_EXPERIMENTAL_GAIN_MAP=ON
- name: Build libavif with [[nodiscard]] (ninja)
if: runner.oldest-cmake == 'false'
working-directory: ./build_nodiscard
Expand Down
2 changes: 2 additions & 0 deletions cmake/Modules/LocalLibargparse.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ else()
libargparse
GIT_REPOSITORY "https://github.com/kmurray/libargparse.git"
GIT_TAG ${AVIF_LOCAL_LIBARGPARSE_GIT_TAG}
# TODO(vrabaud) remove once CMake 3.13 is not supported anymore.
PATCH_COMMAND sed -i.bak -e "s:install.*:include(GNUInstallDirs)\\\\ninstall(TARGETS libargparse RUNTIME DESTINATION \\\\$\\\\{CMAKE_INSTALL_BINDIR\\\\} LIBRARY DESTINATION \\\\$\\\\{CMAKE_INSTALL_LIBDIR\\\\} ARCHIVE DESTINATION \\\\$\\\\{CMAKE_INSTALL_LIBDIR\\\\}):" CMakeLists.txt
UPDATE_COMMAND ""
)
avif_fetchcontent_populate_cmake(libargparse)
Expand Down
Loading