Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use runner.os in artifact archive name #2456

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Oct 1, 2024

"Linux-artifacts.zip" and "macOS-artifacts.zip" should be prettier than "ubuntu-latest-artifacts.zip" and "macos-latest-artifacts.zip".

See https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#runner-context.

"Linux-artifacts.zip" and "macOS-artifacts.zip" should be prettier
than "ubuntu-latest-artifacts.zip" and "macos-latest-artifacts.zip".

[skip ci]
@y-guyon
Copy link
Collaborator Author

y-guyon commented Oct 1, 2024

I wonder if runner.arch should be part of the name of the archive too.

@y-guyon y-guyon merged commit ddb5969 into AOMediaCodec:main Oct 1, 2024
@y-guyon y-guyon deleted the runneros branch October 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants