Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all remaining references to AppVeyor #2451

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

y-guyon
Copy link
Collaborator

@y-guyon y-guyon commented Oct 1, 2024

It was replaced with .github/workflows/ci-windows-artifacts.yml.
Also remove the broken Travis Build Status link.

It was replaced with .github/workflows/ci-windows-artifacts.yml.

[skip ci]
Copy link
Collaborator

@maryla-uc maryla-uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@y-guyon
Copy link
Collaborator Author

y-guyon commented Oct 1, 2024

I do not understand why continuous-integration/appveyor/pr is still part of the presubmit tests.

@y-guyon y-guyon merged commit 7d357d6 into AOMediaCodec:main Oct 1, 2024
1 check failed
@y-guyon y-guyon deleted the appveyor branch October 1, 2024 08:54
maryla-uc pushed a commit to maryla-uc/libavif that referenced this pull request Oct 1, 2024
It was replaced with .github/workflows/ci-windows-artifacts.yml.
Also remove the broken Travis Build Status link.
maryla-uc pushed a commit to maryla-uc/libavif that referenced this pull request Oct 1, 2024
It was replaced with .github/workflows/ci-windows-artifacts.yml.
Also remove the broken Travis Build Status link.
@@ -144,12 +144,10 @@ cmake -S . -B build -DBUILD_SHARED_LIBS=OFF -DAVIF_CODEC_AOM=LOCAL -DAVIF_LIBYUV
cmake --build build --parallel
```

## Prebuilt Library (Windows)
## Prebuilt Static Binaries (Windows)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I suggest removing the word "Static".

It's not clear what "Static" means here. I think it means "statically-linked", i.e., the executables are linked with the libavif static library.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #2462.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also done in #2463.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants