Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace recent-cmake action variable with oldest-cmake #2413

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Replace recent-cmake action variable with oldest-cmake #2413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8969bb4
Replace recent-cmake action variable with oldest-cmake
vrabaud Aug 27, 2024
e06232e
Add comments
vrabaud Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add comments
  • Loading branch information
@vrabaud
vrabaud committed Aug 28, 2024
commit e06232e00fccc94d4bbb3b299fbd7d6fad7a9de5
2 changes: 1 addition & 1 deletion .github/actions/setup-common/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inputs:
description: 'Can take the values: OFF, LOCAL, SYSTEM'
default: 'OFF'
oldest-cmake:
vrabaud marked this conversation as resolved.
Show resolved Hide resolved
description: 'Can take the values: true, false. Only useful on Linux'
description: 'Can take the values: true, false. Only useful on Linux to force using the minimum required CMake'
default: 'false'
runs:
using: "composite"
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci-unix-shared-installed.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,19 @@ jobs:
build-shared-installed:
strategy:
fail-fast: false
# Generate the configurations:
# Ubuntu with gcc 14 with oldest-cmake set to true or false
# OSX with default gcc and CMake (oldest-cmake is unused on OSX)
matrix:
os: [ubuntu-24.04, macos-latest]
oldest-cmake: [false, true]
include:
# Add a gcc version on Ubuntu only
- os: ubuntu-24.04
compiler: gcc
gcc: 14
exclude:
# Do not use the oldest CMake on OSX
- os: macos-latest
oldest-cmake: true
vrabaud marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.os }}
Expand Down
Loading