Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory sanitizer CI #2254

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Add memory sanitizer CI #2254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fa3c25
Add memory sanitizer CI
vrabaud Dec 10, 2024
5a1c9f5
Disable AvifAllocTest.Extremes with msan
vrabaud Jan 13, 2025
9f46ee4
Move memory sanitizer CI to a different file
vrabaud Jan 21, 2025
ef1b91e
Fix comment
vrabaud Jan 21, 2025
79aca72
Fix comments
vrabaud Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comments
  • Loading branch information
@vrabaud
vrabaud committed Jan 22, 2025
commit 79aca7285073b93a03156b845618646e8a158e46
14 changes: 3 additions & 11 deletions .github/workflows/ci-unix-static-sanitized-memory.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,20 +28,13 @@ jobs:
codec-dav1d: "LOCAL"
libyuv: "LOCAL"
extra-cache-key: memory
- uses: ./.github/actions/setup-macos
if: runner.os == 'macOS'
id: setup_macos
with:
codec-aom: "LOCAL"
codec-dav1d: "LOCAL"
extra-cache-key: memory
- id: cache-hit
run: echo "hit=${{ (runner.os == 'Linux' && steps.setup_linux.outputs.ext-cache-hit == 'true') || (runner.os == 'macOS' && steps.setup_macos.outputs.ext-cache-hit == 'true') }}" >> "$GITHUB_OUTPUT"

- name: Build cxx and cxxabi
run: |
# clone LLVM
git clone --depth=1 --branch llvmorg-19.1.6 https://github.com/llvm/llvm-project
git clone --depth=1 --branch llvmorg-19.1.7 https://github.com/llvm/llvm-project
# configure cmake
cmake -G Ninja -S llvm-project/runtimes -B llvm-project/msan_out \
-DCMAKE_BUILD_TYPE=Release \
Expand Down Expand Up @@ -97,7 +90,7 @@ jobs:
- name: Prepare libavif (cmake)
run: >
cmake -S . -B build -G Ninja
-DCMAKE_BUILD_TYPE=Debug -DBUILD_SHARED_LIBS=OFF
-DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_SHARED_LIBS=OFF
-DAVIF_CODEC_AOM=LOCAL -DAVIF_CODEC_DAV1D=LOCAL
-DAVIF_JPEG=LOCAL -DAVIF_LIBSHARPYUV=LOCAL
-DAVIF_LIBYUV=LOCAL -DAVIF_ZLIBPNG=LOCAL
Expand All @@ -114,6 +107,5 @@ jobs:
working-directory: ./build
run: ctest -j $(getconf _NPROCESSORS_ONLN) --output-on-failure
env:
ASAN_OPTIONS: allocator_may_return_null=1
TSAN_OPTIONS: allocator_may_return_null=1
MSAN_OPTIONS: allocator_may_return_null=1
LD_LIBRARY_PATH: ${{ env.CI_LD_LIBRARY_PATH }}
1 change: 1 addition & 0 deletions .github/workflows/ci-unix-static-sanitized.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
# Memory sanitizer needs to be in its own file because it is slower than other sanitizers.
sanitizer: [address, thread, undefined]
vrabaud marked this conversation as resolved.
Show resolved Hide resolved

env:
Expand Down
2 changes: 1 addition & 1 deletion tests/gtest/avifallocationtest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ TEST(EncodingTest, MaximumInvalidDimensions) {
AVIF_RESULT_UNSUPPORTED_DEPTH);
}

#if defined(__clang__) && defined(__has_feature)
#if defined(__has_feature)
#if __has_feature(memory_sanitizer)
#define TEST_EXTREMES 0
#else
Expand Down
Loading