Skip to content

idx_mask computation inside the precision loop - #5501

Merged
urvangjoshi merged 2 commits into
AOMediaCodec:av2-encfrom
jianle973:ref_mv_idx_speed_up
Oct 7, 2026
Merged

urvangjoshi merged 2 commits into
AOMediaCodec:av2-encfrom
jianle973:ref_mv_idx_speed_up

Conversation

@jianle973

@jianle973 jianle973 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Move ref_mv_idx_to_search() from the pre-loop into the real BAWP rd search loop. The 33-frame test results are (on top of commit 63e3858, sep-30) as follows, average results of A1-5 and B1:

     psnr-y psnr-u psnr-v psnr-yuv enc-time dec-time

speed 1: 0.00% -0.00% +0.01% +0.00% 99.52% 99.78%
speed 2: -0.00% +0.00% -0.00% -0.00% 99.16% 98.89%

@yeqing-wu

yeqing-wu commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Move ref_mv_idx_to_search() from the pre-loop into the real BAWP rd search loop. The 33-frame $A test results are (on top of commit 63e3858, sep-30) as follows, average results of A1-5 and B1:

     psnr-y psnr-u psnr-v psnr-yuv enc-time dec-time

speed 1: 0.00% -0.00% +0.01% +0.00% 99.52% 99.78% speed 2: -0.00% +0.00% -0.00% -0.00% 99.16% 98.89%

I think we have some format issues for the commit body message. what is $A?

@jianle973

Copy link
Copy Markdown
Contributor Author

Move ref_mv_idx_to_search() from the pre-loop into the real BAWP rd search loop. The 33-frame $A test results are (on top of commit 63e3858, sep-30) as follows, average results of A1-5 and B1:

     psnr-y psnr-u psnr-v psnr-yuv enc-time dec-time

speed 1: 0.00% -0.00% +0.01% +0.00% 99.52% 99.78% speed 2: -0.00% +0.00% -0.00% -0.00% 99.16% 98.89%

I think we have some format issues for the commit body message. what is $A?

It's a typo. Fixed.

@yeqing-wu yeqing-wu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments. Thanks

Comment thread av2/encoder/rdopt.c Outdated
@jianle973
jianle973 force-pushed the ref_mv_idx_speed_up branch 2 times, most recently from faa2ded to 415f5a9 Compare October 7, 2026 22:58

@yeqing-wu yeqing-wu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@urvangjoshi
urvangjoshi merged commit ad01223 into AOMediaCodec:av2-enc Oct 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants