Skip to content

Support the required flag on resource properties (Discovery and Swagger) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

clementdenis
Copy link

@clementdenis clementdenis commented Sep 4, 2019

This change is Reviewable

@clementdenis clementdenis force-pushed the required_resource_field branch from ea958f4 to f009e19 Compare September 4, 2019 15:04
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #41 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #41      +/-   ##
============================================
+ Coverage     82.19%   82.24%   +0.05%     
- Complexity     1845     1855      +10     
============================================
  Files           158      158              
  Lines          6672     6692      +20     
  Branches        880      886       +6     
============================================
+ Hits           5484     5504      +20     
  Misses          866      866              
  Partials        322      322
Impacted Files Coverage Δ Complexity Δ
...com/google/api/server/spi/config/model/Schema.java 100% <ø> (ø) 2 <0> (ø) ⬇️
...e/api/server/spi/discovery/DiscoveryGenerator.java 92.11% <100%> (+0.05%) 64 <0> (+1) ⬆️
...oogle/api/server/spi/swagger/SwaggerGenerator.java 91.66% <100%> (+0.03%) 150 <0> (+1) ⬆️
.../api/server/spi/config/ResourcePropertySchema.java 68.18% <100%> (+5.02%) 9 <2> (+2) ⬆️
.../api/server/spi/config/model/SchemaRepository.java 93.82% <100%> (+0.07%) 44 <0> (+1) ⬆️
...ig/annotationreader/ApiAnnotationIntrospector.java 96.47% <100%> (+0.47%) 34 <5> (+5) ⬆️
...nfig/jsonwriter/JacksonResourceSchemaProvider.java 80.35% <100%> (+0.35%) 17 <0> (ø) ⬇️
...rc/main/java/com/google/api/server/spi/IoUtil.java 59.52% <100%> (ø) 14 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d6a2e...d2c4455. Read the comment docs.

Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 20 of 20 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


endpoints-framework/src/test/java/com/google/api/server/spi/config/model/SchemaRepositoryTest.java, line 282 at r1 (raw file):

resrouce

resource

@clementdenis clementdenis force-pushed the required_resource_field branch from f009e19 to d2c4455 Compare September 10, 2019 10:13
Copy link

@llbrt llbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@clementdenis clementdenis merged commit debb8cb into master Sep 16, 2019
@clementdenis clementdenis deleted the required_resource_field branch September 16, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants