-
Notifications
You must be signed in to change notification settings - Fork 5
Improve generated Swagger spec compatibility with Endpoints Portal #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
clementdenis
commented
Jul 30, 2019
- Support Endpoints Portal authorization flow
- Add authorizationUrl and useScopesInAuthFlow issuer config params
- Define default authorizationUrl for Google id token issuers
- Add scopes in operation's security (required for Try it! in Portal)
- Add authorizationUrl in OAuth2 flow (required for Try it! in Portal)
- Reorder Google id token issuers to have https:// one first
- New supported Swagger features
- Support deprecation on Swagger operations with @deprecated
- Add tags to Swagger operations to group like API Explorer in Portal
- Inline Map types (including JsonMap) to avoid useless definitions
- Set default values for parameters
- Add proper collection format (multi instead of csv)
- List unsupported features of the spec in UNSUPPORTED_FEATURES.md
- Order consistency
- Remove ordering attempt in reflection-based introspection
- Add ordering in Swagger generation (sort paths by string order)
- Testing
- Improve coverage of SwaggerGenerator (array tests)
- Extract Swagger assertion logic in a truth.dev subject
- Update truth.dev to 1.0
- Cleanup
- Remove writeInternal boolean in SwaggerGenerator (not used)
* Support Endpoints Portal authorization flow - Add authorizationUrl and useScopesInAuthFlow issuer config params - Define default authorizationUrl for Google id token issuers - Add scopes in operation's security (required for Try it! in Portal) - Add authorizationUrl in OAuth2 flow (required for Try it! in Portal) - Reorder Google id token issuers to have https:// one first * New supported Swagger features - Support deprecation on Swagger operations with @deprecated - Add tags to Swagger operations to group like API Explorer in Portal - Inline Map types (including JsonMap) to avoid useless definitions - Set default values for parameters - Add proper collection format (multi instead of csv) - List unsupported features of the spec in UNSUPPORTED_FEATURES.md * Order consistency - Remove ordering attempt in reflection-based introspection - Add ordering in Swagger generation (sort paths by string order) * Testing - Improve coverage of SwaggerGenerator (array tests) - Extract Swagger assertion logic in a truth.dev subject - Update truth.dev to 1.0 * Cleanup - Remove writeInternal boolean in SwaggerGenerator (not used)
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
===========================================
+ Coverage 81.14% 81.6% +0.46%
- Complexity 1738 1775 +37
===========================================
Files 159 159
Lines 6432 6495 +63
Branches 842 856 +14
===========================================
+ Hits 5219 5300 +81
+ Misses 900 875 -25
- Partials 313 320 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks ok but to be honest I can't assure it. Let's merge and see :)
(It could have been splited in various PRs and/or commits. For remaining swagger features, if we do support them, I suggest to create 1 PR by feature).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Reviewed 1 of 40 files at r1.
Reviewable status: 1 of 40 files reviewed, all discussions resolved (waiting on @llbrt and @RaHery)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 40 files reviewed, all discussions resolved (waiting on @llbrt and @RaHery)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 39 of 40 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @llbrt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 40 of 40 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved