This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
[IMP] send batch of names/comments instead of 1 by 1 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The code in skelenox and on the server side has been improved, in order to send a batch of names and comments per POST when skelenox starts, instead of one per POST request. Even if it is still quite long, it considerably reduces the first early actions of this IDA Python script.
For now, I kept the methods push_name and push_comment of the SkelIDAConnection class and created the methods push_names and push_comments in order to send the whole thing at once. The script api_idaactions has been adapted to handle lists of values. I think the former methods could be removed for the 2.0.
I will probably update the tests scripts too.