Skip to content

Improve and clean pybindings #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 94 commits into
base: master
Choose a base branch
from
Open

Improve and clean pybindings #260

wants to merge 94 commits into from

Conversation

extiop
Copy link
Contributor

@extiop extiop commented Mar 27, 2025 •
edited
Loading

Reviewed by @sashaconway up to 6ea5484

It would also be interesting to split and rename (as MLAFile is ambiguous) MLAFile into MLAReader and MLAWriter :

  • MLAReader
  • MLAWriter

commial added 30 commits August 1, 2024 18:45
@commial
CI: launch tests on all PR
bd7f394
@commial
Encryption layer: add a key commitment scheme
939bd2b
@commial
Encryption layer: explicit ASSOCIATED_DATA (set to an empty string)
2c2e1fb
@commial
Bindings/C: update generated headers
b10353d
@commial
Encrypt: for 256-bits of security, a 512bits chain is needed
cd60e9d
@commial
Encrypt: force CryptoRngCore on the CSPRNG used
cda1dd2
@commial
Config: split configuration into persistent and internal, avoiding "k…
63f10f8 
…ey" outside MLA
@commial
Bindings/C: update with new error code
5079cfa
@commial
Crypto: introduce hybrid PQC cryptography, based on ECC and ML-KEM
b5842a2
@commial
Crypto/ecc: simple code refactoring
4900f78
@commial
Encrypt: !breaking! switch Encrypt layer from ECC to hybrid cryptography
b6eb9e8
@commial
Encrypt/ECC: remove no more used code
e56ffa7
@commial
Curve: rename to mlakey-parser
011275e
@commial
Mlakey: add DER parsing of hybrid keys
4e83fa7
@commial
Mlakey: add PEM parsing
bbc5139
@commial
Mlakey: add DER & PEM export
f71d5d7
@commial
Mlakey: add more tests
27b7c03
@commial
Mlakey: use core instead of std, to ease possible future no_std
222240a
@commial
mla: rename Key parsing error to remove ECC mention
dc56cb9
@commial
Hybrid: add custom zeroize while ml_kem doesn't provide one
b5fc8f8
@commial
Mlar: use the new key format
797e114
@commial
mlar: update integration tests
92395e2
@commial
Bindings/C: switch to mlakey-parser, update error codes
85d3d67
@commial
Mla/Fuzz: switch to mlakey-parser
302a46f
@commial
Bench: fix mlakey-parser use
c97cac8
@commial
CI: update to mlakey-parser
13c02d4
@commial
Mla/tests: temporary comment unused tests utils
3cd1b51
@commial
bindings/C: dynamic import of public key files
2bd4491
@commial
bindings/C/tests: cleanup
3b819c7
@commial
bindings/C/tests: update error code
27c0c52
extiop added 22 commits November 28, 2024 15:53
@extiop
Fix MathJax syntax
b2c1b4d
@extiop
clippy fix + review from @sashaconway + rename hybrid encapsulation k…
b38e9a0 
…ey + dual PRF hash moved from sha256 to sha512
@extiop
clippy fix
38e5c79
@extiop
Merge pull request ANSSI-FR#220 from ANSSI-FR/hpke
59ab36f 
Use HPKE
@extiop
Upgrade to 2024 rust edition
91d74a3
@extiop
WIP: upgrade crates
00ab67f
@extiop
mlar: Update test according to ml-kem update to follow FIPS 203
20b3bc5
@extiop
mlar: format fix
d55982c
@extiop
Merge pull request ANSSI-FR#251 from extiop/doc-crypto
dc72632 
Doc crypto : update dependencies
@extiop
rm merge conflicts
d989ea4
@extiop
fix merge conflicts
9d9adfe
@extiop
pybindings: add Sync for MLAFile
bed4cea
@extiop
WIP: pyO3 latest update
bcbf246
@extiop
rm unsafe Sync trait + add Bound py object and PyTuple in pymethods
4f05570
@extiop
Cargo lock update
22a8c5f
@extiop
Thread safety with Mutex
0f5a78d
@extiop
format + ignore poisoned Mutex as thread are safe
3e11aed
@extiop
Refactor code as MLAFile methods and remove macro check_mode
cddbebb
@extiop
Unwrap potential Mutex panic + format
d432253
@extiop
Fix double lock for repr
7d3d352
@extiop
rm unnecessary Cow usage
0f83c33
@extiop
reduce dependency to __repr__ on strings with to_owned + minor fixes
6ea5484
@extiop extiop added dependencies Pull requests that update a dependency file binding Concerns the bindings rust Pull requests that update Rust code labels Mar 27, 2025
@extiop extiop force-pushed the improve-and-clean-pybindings branch from 9117784 to 6ea5484 Compare March 27, 2025 16:47
@extiop extiop changed the base branch from doc-crypto to formatv2 March 27, 2025 16:49
@extiop extiop changed the base branch from formatv2 to master March 27, 2025 16:50
@extiop
Copy link
Contributor Author

extiop commented Mar 28, 2025

Mergeable after #258 is merged

@extiop extiop added this to the Format v2 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
binding Concerns the bindings dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Milestone
mla v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@extiop @commial