add crossbeam scoped thread #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ANLAB-Support
force-pushed
the
feature-crossbeam-thread
branch
from
906dc5c to
18cb1d4
Compare
|
bors try |
|
bors retry |
tryAlready running a review |
|
bors try- |
|
bors try |
tryBuild succeeded: |
jeehoonkang
requested changes
Aug 5, 2020
dpdk/src/eal.rs
Outdated
|
|
||
| /// Launch a thread pined to this core. | ||
| /// TODO: change it to crossbeam's `spawn` signature when we start to use crossbeam. | ||
| pub fn launch_scoped<'scope, 'env, F, T>( |
There was a problem hiding this comment.
lifetime이 좀 복잡해보이는데 왜 두개가 필요한가요?
There was a problem hiding this comment.
그리고 전통대로lifetime name은 한글자로 합시다.
There was a problem hiding this comment.
scope 를 외부에서 공급받는 형태라서 그런 것 같습니다.
-
넵. 저는 큰 선호가 없습니다만 crossbeam 에서 쓰던 convention을 그대로 가져오는게 좋지 않나 싶어서 우선 그쪽 naming을 차용했습니다.
-
고민을 해 보았습니다만 (std vs 3rdparty) 애초에 Rust std 의 thread launch 모델이 좋은 것 같지 않아서 아예 crossbeam 으로 대체하는게 좋겠습니다. 넵 좋습니다.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.