Repository navigation
feat: report a problem from Settings, judged before it becomes a GitHub issue - #83
Merged
Merged
Conversation
…files them on GitHub
… the SkillNet team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
People can now report a problem from Settings. A model reads the report, throws out spam, rewrites it without personal details, checks the open issues for a duplicate, and files an issue or comments on the existing one.
What's in it:
bug_reportstable (migration 0038) andPOST /bugs,GET /bugs/mine, and for adminsGET /bugs,POST /bugs/{id}/fileandPOST /bugs/{id}/discard. The report is saved before it's judged, so a model or GitHub failure loses nothing. A person can send 5 a day (BUG_REPORT_DAILY_LIMIT), admins have no cap.apps/skillnet-relayis a small service that receives reports from any instance and files them with its own GitHub token, so the token never lives in an instance or in the code. It limits reports per address, per instance and per day, and it judges every report itself rather than trusting the instance. It has its own Dockerfile (docker/relay.Dockerfile).Sharing with the team is off by default and only the admin can turn it on. Only the title, the text, the page and the browser are sent, never a name, an email or an organization. If the relay can't be reached, the instance judges the report itself, so sharing never costs a report. With no
GITHUB_TOKENandGITHUB_REPOnothing leaves the deployment.I also tied
Textarea's label to its field, the wayInputalready does.Testing:
test_llm_client.py::test_a_model_whose_thinking_is_opt_in_is_left_alone, which fails the same way onmainanddevelop.Not done yet: deploying the relay and pointing
reports.skillnet.esat it. Until then the switch has nothing to send to, and reports fall back to being judged in the instance.