Skip to content

Commit

Permalink
Fix datagrid lines (opensearch-project#1250)
Browse files Browse the repository at this point in the history
Signed-off-by: Miki <miki@amazon.com>
  • Loading branch information
AMoo-Miki authored Feb 9, 2024
1 parent cf5915d commit 543435a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 15 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
- Prevent collapsable button of a resizable from adding to the height when hidden ([#1241](https://github.com/opensearch-project/oui/pull/1241))
- Prevent action buttons of OuiDataGridCell from moving the content ([#1224](https://github.com/opensearch-project/oui/pull/1224))
- Fix vertical alignment and font weight of breadcrumbs that are buttons or links ([#1232](https://github.com/opensearch-project/oui/pull/1232))
- Fix datagrid lines ([#1250](https://github.com/opensearch-project/oui/pull/1250))

### 🚞 Infrastructure

Expand Down
32 changes: 17 additions & 15 deletions src/components/datagrid/_data_grid_data_row.scss
Original file line number Diff line number Diff line change
Expand Up @@ -166,21 +166,6 @@
}

.ouiDataGridRowCell {
box-shadow: none !important; // sass-lint:disable-line no-important

/* ToDo: Remove unnecessary logic: the old beta theme has
* evolved and the statement below about the `Next` theme
* is not valid.
*/
// Remove default .ouiButtonIcon--fill border
// This way we don't need to animate the border that is inexistent in Next and unnecessary for a fill button
border: none;

&-isActive {
margin-left: $ouiDataGridCellPaddingM;
width: $ouiSizeM;
}

&__actionButtonIcon,
&__expandButtonIcon {
height: $ouiSizeM;
Expand All @@ -190,6 +175,23 @@
transition: none; // Have to take out the generic transition so it is instantaneous on focus
}

&__expandButtonIcon {
box-shadow: none !important; // sass-lint:disable-line no-important

/* ToDo: Remove unnecessary logic: the old beta theme has
* evolved and the statement below about the `Next` theme
* is not valid.
*/
// Remove default .ouiButtonIcon--fill border
// This way we don't need to animate the border that is inexistent in Next and unnecessary for a fill button
border: none;

&-isActive {
margin-left: $ouiDataGridCellPaddingM;
width: $ouiSizeM;
}
}

&__expandButton > * {
z-index: 2;
}
Expand Down

0 comments on commit 543435a

Please sign in to comment.