Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move dcvpdtemp #439

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Move dcvpdtemp #439

merged 1 commit into from
Oct 31, 2023

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Oct 30, 2023

No description provided.

@marchdf marchdf force-pushed the move-dcvpdtemp branch 2 times, most recently from 35724ff to 8243ee5 Compare October 30, 2023 20:44
@marchdf marchdf marked this pull request as ready for review October 30, 2023 21:40
malihass
malihass approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@malihass malihass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a way to move the dcvpRdT call without it showing changes in the mechs, that would be great! Otherwise it is ok as is!

@marchdf
Copy link
Contributor Author

marchdf commented Oct 31, 2023

Yeah I wish I could... I tried but couldn't make it happen.

@marchdf marchdf merged commit 276ca0b into development Oct 31, 2023
@marchdf marchdf deleted the move-dcvpdtemp branch October 31, 2023 15:22
baperry2 added a commit that referenced this pull request Dec 1, 2023
@baperry2 @marchdf @jrood-nrel
Filter Utility (#445)
769ae63 
* Explicit filtering of hydro fluxes and source term. (#112)

This commit implements explicit filtering of the hydro fluxes and
source term (for both MOL and PPM code paths). This is necessary to
perform explicitly filtered Large Eddy Simulations.

Contains:
- regressions tests
- documentation
- CMake implementation

* Remove legacy Fortran code. (#252)

* Use default for trivial constructors and only build HIP in CI for gfx908 (#434)

* Use default for trivial constructors.

* Only build HIP in CI for gfx908.

* Update PelePhysics.

* Fixes to header files (#439)

* Fixes to header files.

* Update PelePhysics submodule.

* More fixes.

* Initialize xdiff in HIT.

* Invert some mfiter loops (#446)

Co-authored-by: Jon Rood <jon.rood@nrel.gov>

* Add GPU syncs because MF ParallelFor is non-blocking (#471)

* Rename header guards (#506)

* Replace _OPENMP with AMREX_USE_OMP to support Ascent. (#519)

* Address some warnings (#554)

* remove dependence of Filter on Utilities (#710)

* move files

* docs for filter

* use amrex Pi instead of PeleC Pi

---------

Co-authored-by: Marc T. Henry de Frahan <marc.henrydefrahan@nrel.gov>
Co-authored-by: Jon Rood <jon.rood@nrel.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baperry2 baperry2 baperry2 approved these changes

@malihass malihass malihass approved these changes

@jrood-nrel jrood-nrel Awaiting requested review from jrood-nrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marchdf @malihass @baperry2