Repository navigation
Mirror synced rubber-band zooms through requested regions - #246
Open
WeiqunZhang wants to merge 2 commits into
Open
WeiqunZhang wants to merge 2 commits into
WeiqunZhang wants to merge 2 commits into
Conversation
The other panels took a selection as fractions of the plane each was displaying. With the previous zoom's slice still in flight on a slow connection, that plane predates the zoom, so the siblings restated the old region and stayed a zoom behind for good. Mirror through the region each panel has asked for instead. Adds a gated smoke test that lands the source panel's slice first, and a 32-cell 3-D fixture it needs. Fixes AMReX-Codes#243.
# Conflicts: # src/qt/MainWindow.hpp # src/qt/MainWindowInteraction.cpp # src/qt/MainWindowInternal.hpp # src/qt/PlaneMapping.hpp # src/qt/SmokeHarnessZoom.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The other panels took a selection as fractions of the plane each was displaying. With the previous zoom's slice still in flight on a slow connection, that plane predates the zoom, so the siblings restated the old region and stayed a zoom behind for good. Mirror through the region each panel has asked for instead. Adds a gated smoke test that lands the source panel's slice first, and a 32-cell 3-D fixture it needs.
Fixes #243.