Skip to content

Add symlog colorbar scaling option - #229

Open
BenWibking wants to merge 11 commits into
AMReX-Codes:mainfrom
BenWibking:symlog
Open

BenWibking wants to merge 11 commits into
AMReX-Codes:mainfrom
BenWibking:symlog

Conversation

@BenWibking

@BenWibking BenWibking commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Adds a matplotlib-style symlog colorbar scaling option.

A lot of code churn is required to change bool to enum for the color bar scaling settings.

Fixes #226.

@BenWibking BenWibking changed the title add symlog scaling option Add symlog colorbar scaling option Sep 5, 2026
@BenWibking
BenWibking marked this pull request as ready for review September 5, 2026 18:58
@WeiqunZhang

Copy link
Copy Markdown
Member

• [P2] Preserve toolbar focus across dataset reopening — SmokeHarnessZoom.cpp:648
(

// Use a control that stays enabled across an open. The
)

At 640×480, reopening a dataset while the Level combo has focus moves focus into the image view; the next Up key pans the image. The base revision leaves focus on a toolbar combo and generates
no pan request. The added toolbar controls change focus routing when teardown disables the Level combo. Retargeting this test to the metadata tree leaves that regression uncovered. Preserve
control focus across reopening and retain the Level-focused regression case.

@WeiqunZhang

Copy link
Copy Markdown
Member

• Request changes: the P2 focus regression remains at 62b2394.

[P2] Preserve toolbar focus across dataset reopening — SmokeHarnessZoom.cpp:648
(

// Use a control that stays enabled across an open. The
)

At 640×480, reopening a dataset with the Level combo focused moves focus into the image view; the next Up key generates a pan request. Reproduced on this head. Preserve control focus across
reopening and retain the Level-focused regression case instead of testing only the metadata tree.

The new commit changes only vector glyph code, documentation, and tests; it does not address this finding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom NaN color

2 participants