CMake: improve MSVC+CUDA support #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary issue now is that nvcc doesn't seem to be parsing with /Za enabled, so alternate tokens are causing compile failures.
robertmaynard
commented
Jun 10, 2020
| @@ -94,10 +94,17 @@ add_library(AMReX::Flags_CXX_REQUIRED ALIAS Flags_CXX_REQUIRED) | |||
|
|
|||
| target_compile_options( Flags_CXX_REQUIRED | |||
| INTERFACE | |||
| $<${_cxx_msvc}:/Za /bigobj | |||
There was a problem hiding this comment.
FYI: CMake generator expressions can't span multiple lines so these two lines had to change no matter what
ax3l
approved these changes
Jun 10, 2020
|
Rebased my GH Action test now, let's see: https://github.com/ax3l/amrex/actions |
mic84
added a commit
to mic84/amrex
that referenced
this pull request
Jun 11, 2020
mic84
added a commit
that referenced
this pull request
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary issue now is that nvcc doesn't seem to be parsing with
/Za enabled, so alternate tokens are causing compile failures.