Parser: Support User defined functions #4425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depend on #4442. |
WeiqunZhang
force-pushed
the
parser_uf
branch
5 times, most recently
from
1739a58 to
495c0aa
Compare
The user defined functions can have up to 4 arguments. If more is needed, we can support it in the future. Getting device function pointers requires GPU relocatable device code (RDC) support. Moreover, these user defined device functions should be defined in cpp files not headers to ensure the function pointers are unique. For now, we only support CPU, CUDA, and HIP. In the future, we can try to support SYCL.
atmyers
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user defined functions can have up to 4 arguments. If more is needed, we can support it in the future. Getting device function pointers requires GPU relocatable device code (RDC) support. Moreover, these user defined device functions should be defined in cpp files not headers to ensure the function pointers are unique.
For now, we only support CPU, CUDA, and HIP. In the future, we can try to support SYCL.