Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ParmParse Parser more robust #4291

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Make ParmParse Parser more robust #4291

merged 1 commit into from
Jan 12, 2025

Conversation

WeiqunZhang
Copy link
Member

It's now allowed to call ParmParse Parser functions (e.g., queryAddWithParser) outside OpenMP parallel regions before ParmParse is initialized.

@WeiqunZhang
Make ParmParse Parser more robust
2e7c3e0 
It's now allowed to call ParmParse Parser functions (e.g.,
queryAddWithParser) outside OpenMP parallel regions before ParmParse is
initialized.
@WeiqunZhang WeiqunZhang requested a review from ax3l January 11, 2025 22:31
@WeiqunZhang WeiqunZhang mentioned this pull request Jan 11, 2025
Merged
2 tasks
@ax3l ax3l self-assigned this Jan 12, 2025
ax3l
ax3l approved these changes Jan 12, 2025
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ax3l ax3l merged commit f6d3d70 into AMReX-Codes:development Jan 12, 2025
75 checks passed
@ax3l ax3l mentioned this pull request Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeiqunZhang @ax3l