Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use perl instead of sed in style checks for portability to MacOS #4127

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

baperry2
Copy link
Contributor

@baperry2 baperry2 commented Sep 3, 2024

Summary

sed -i does not function the same for GNU and BSD sed and a simple portable command between the two is apparently not possible. Therefore, the style check scripts do not work by default when running on Macs, unless the user installs gsed and aliases sed to run that instead. For portability,perl can be used instead of sed.

Additional background

Proposed solution taken from here: https://stackoverflow.com/questions/4247068/sed-command-with-i-option-failing-on-mac-but-works-on-linux

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit 61b91f9 into AMReX-Codes:development Sep 4, 2024
59 checks passed
@baperry2 baperry2 deleted the style-check-perl branch September 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants