Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDF5: Correctly choose datatype of plotfile based on RD numBytes #4006

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

arnav-singhal
Copy link
Contributor

@arnav-singhal arnav-singhal commented Jun 25, 2024

Summary

If numBytes is 4, use H5T_NATIVE_FLOAT instead of H5T_NATIVE_DOUBLE. This fixes writing real values, as in ExaEpi.

Additional background

As far as I can tell, whichRD (and therefore whichRDBytes) does not change between levels, so I perform this check outside of the level loop, but if it is indeed possible for these values to change, I can move it inside.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers
Copy link
Member

atmyers commented Jun 28, 2024

Thanks!

@atmyers atmyers merged commit 73e46e6 into AMReX-Codes:development Jun 28, 2024
70 checks passed
@arnav-singhal arnav-singhal deleted the main branch July 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants