Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding physical and math BC types for inflow-outflow BCs #3965

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

mukul1992
Copy link
Contributor

Summary

This feature would be useful for managing boundaries with both inflow and outflow cells. By adding these types in AMReX, they can be used consistently across various inter-dependent codes such as IAMR, AMReX-Hydro, and AMR-Wind.

Additional background

The ongoing addition of an inflow-outflow BC in AMR-Wind is the primary motivation.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit baa16a6 into AMReX-Codes:development Jun 2, 2024
68 of 69 checks passed
@mukul1992 mukul1992 deleted the addIObc branch June 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants