Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GOVERNANCE.rst, based on the WarpX model #3917

Merged
merged 9 commits into from
May 8, 2024
Merged

Add GOVERNANCE.rst, based on the WarpX model #3917

merged 9 commits into from
May 8, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented May 1, 2024

This is a draft of the GOVERNANCE.rst file for AMReX, required for HPSF membership.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

atmyers
atmyers commented May 1, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
ax3l
ax3l reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
@atmyers atmyers requested a review from cgilet May 2, 2024 19:36
@WeiqunZhang WeiqunZhang requested a review from drummerdoc May 2, 2024 19:49
jbbel
jbbel reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
asalmgren
asalmgren reviewed May 2, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
@atmyers atmyers marked this pull request as ready for review May 3, 2024 00:37
@atmyers atmyers changed the title [WIP] Add GOVERNANCE.rst, based on the WarpX model Add GOVERNANCE.rst, based on the WarpX model May 3, 2024
asalmgren
asalmgren reviewed May 3, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
WeiqunZhang
WeiqunZhang reviewed May 3, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
WeiqunZhang
WeiqunZhang reviewed May 3, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
WeiqunZhang
WeiqunZhang reviewed May 3, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
WeiqunZhang
WeiqunZhang reviewed May 3, 2024
View reviewed changes
GOVERNANCE.rst Outdated Show resolved Hide resolved
@ax3l ax3l mentioned this pull request May 3, 2024
Open
@atmyers @WeiqunZhang
@ax3l @asalmgren
Apply suggestions from code review
9570962 
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
Co-authored-by: Ann Almgren <asalmgren@lbl.gov>
@WeiqunZhang WeiqunZhang requested a review from kngott May 3, 2024 22:00
atmyers
atmyers commented May 7, 2024
View reviewed changes
GOVERNANCE.rst Show resolved Hide resolved
@WeiqunZhang WeiqunZhang requested review from ajnonaka and jmsexton03 May 7, 2024 23:54
@asalmgren asalmgren self-requested a review May 8, 2024 00:02
@asalmgren asalmgren requested a review from jbbel May 8, 2024 00:02
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) May 8, 2024 00:22
@WeiqunZhang WeiqunZhang merged commit 09a109a into AMReX-Codes:development May 8, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngott kngott kngott approved these changes

@jmsexton03 jmsexton03 jmsexton03 approved these changes

@jbbel jbbel jbbel approved these changes

@cgilet cgilet cgilet approved these changes

@asalmgren asalmgren asalmgren approved these changes

@ajnonaka ajnonaka ajnonaka approved these changes

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@zingale zingale zingale approved these changes

@drummerdoc drummerdoc drummerdoc approved these changes

@ax3l ax3l ax3l approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.