Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In allocateSlice, handle empty list of boxes #3808

Merged

Conversation

dpgrote
Copy link
Contributor

@dpgrote dpgrote commented Mar 16, 2024

Summary

In allocateSlice (which is called by get_slice_data in Src/Base/AMReX_MultiFabUtil.cpp) handle the case when no intersection is found between the slice and the box array.

Additional background

When no intersection is found, the boxes array will be empty which would cause a segfault if the data would be accessed. The fix is to return nullptr in this case.
Also, get_slice_data is modified to return nullptr in this case as well.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit 54e438a into AMReX-Codes:development Mar 16, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants