In allocateSlice, handle empty list of boxes #3808
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
allocateSlice
(which is called byget_slice_data
inSrc/Base/AMReX_MultiFabUtil.cpp
) handle the case when no intersection is found between the slice and the box array.Additional background
When no intersection is found, the
boxes
array will be empty which would cause a segfault if thedata
would be accessed. The fix is to returnnullptr
in this case.Also,
get_slice_data
is modified to returnnullptr
in this case as well.Checklist
The proposed changes: