Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in TableData::operator= #3807

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

WeiqunZhang
Copy link
Member

Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think the copy constructor might need the same logic usually, does it?

@WeiqunZhang
Copy link
Member Author

WeiqunZhang commented Mar 21, 2024 via email

@WeiqunZhang WeiqunZhang merged commit ae747cd into AMReX-Codes:development Mar 21, 2024
69 checks passed
@WeiqunZhang WeiqunZhang deleted the table_data_bug branch March 21, 2024 14:34
@ax3l
Copy link
Member

ax3l commented Mar 25, 2024

@WeiqunZhang I actually meant the move constructor, but I think that's not needed there after all (nothing to clear from a previous allocation).

@ax3l ax3l self-assigned this Mar 25, 2024
@WeiqunZhang
Copy link
Member Author

WeiqunZhang commented Mar 25, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants