Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Windows MSVC w/ Ninja #3804

Merged
merged 2 commits into from
Mar 14, 2024
Merged

CI: Windows MSVC w/ Ninja #3804

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73babfe
CI: Windows MSVC w/ Ninja
ax3l Mar 14, 2024
5b0c8b3
Skip Ninja
ax3l Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
CI: Windows MSVC w/ Ninja 
It looks like `-G "Ninja"` swapped the compiler from MSVC
to MinGW (GCC). This ensures MSVC is actually used and
tested in CI.
  • Loading branch information
@ax3l
ax3l committed Mar 14, 2024
commit 73babfe47e3eabd427d67d794808589a8b6a85bc
6 changes: 6 additions & 0 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ jobs:
# Invoke-WebRequest https://github.com/ccache/ccache/releases/download/v4.8/ccache-4.8-windows-x86_64.zip -OutFile ccache-4.8-windows-x86_64.zip
# Expand-Archive ccache-4.8-windows-x86_64.zip
- name: Build & Install
env:
CC: "cl.exe"
CXX: "cl.exe"
run: |
#$ccachepath = Join-Path $pwd "ccache-4.8-windows-x86_64"
#$Env:PATH += ";$ccachepath"
Expand Down Expand Up @@ -70,6 +73,9 @@ jobs:
# Invoke-WebRequest https://github.com/ccache/ccache/releases/download/v4.8/ccache-4.8-windows-x86_64.zip -OutFile ccache-4.8-windows-x86_64.zip
# Expand-Archive ccache-4.8-windows-x86_64.zip
- name: Build & Install
env:
CC: "cl.exe"
CXX: "cl.exe"
run: |
#$ccachepath = Join-Path $pwd "ccache-4.8-windows-x86_64"
#$Env:PATH += ";$ccachepath"
Expand Down
Loading