Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fortran interface for average_down_faces #3553

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

WeiqunZhang
Copy link
Member

No description provided.

@akashdhruv
Copy link
Contributor

fgeom is missing

@WeiqunZhang
Copy link
Member Author

The fine level geometry is not needed. The data on the fine level is constant. On the coarse level we need to make sure that the data on periodic faces are consistent. Thus we need the coarse level geometry.

@akashdhruv
Copy link
Contributor

Divergence is still not zero at the boundary. I will add a figure for reference to #327

@akashdhruv
Copy link
Contributor

The fine level geometry is not needed. The data on the fine level is constant. On the coarse level we need to make sure that the data on periodic faces are consistent. Thus we need the coarse level geometry.

Ok. Thank you.

@WeiqunZhang
Copy link
Member Author

It could be something else. But first, we need to make sure this function is being used. In the test you set up, it is not. Then we can print out the divergence before and after fillpatch to see if the divergence comes from fillpath or other parts of the code.

@akashdhruv
Copy link
Contributor

I have tested this PR on Flash-X side and the test suite is passing. The only issue is with divergence which needs to be investigated on my end. I will be performing the investigations here:

https://github.com/Lab-Notebooks/AMReX-Divfree

However, it shouldn't hold this PR back. Waiting on this PR to merge another Flash-X PR.

@akashdhruv
Copy link
Contributor

@atmyers Can you let me know when you can merge this?

@atmyers atmyers merged commit f08b40b into AMReX-Codes:development Sep 25, 2023
66 checks passed
@WeiqunZhang WeiqunZhang deleted the fi_avgdown_faces branch October 13, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants