Check for small cell before checking for multi-cut #3088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up on AMReX-Codes#3087. There are cases with 5 faces covered and one face still open. These cells should be marked small cells before the multi-cut check.
cgilet
approved these changes
Jan 5, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+48
to
+56
| if (((axm == 0.0_rt && axp == 0.0_rt) && | ||
| (aym == 0.0_rt && ayp == 0.0_rt) && | ||
| (azm == 0.0_rt || azp == 0.0_rt)) || | ||
| ((axm == 0.0_rt && axp == 0.0_rt) && | ||
| (aym == 0.0_rt || ayp == 0.0_rt) && | ||
| (azm == 0.0_rt && azp == 0.0_rt)) || | ||
| ((axm == 0.0_rt || axp == 0.0_rt) && | ||
| (aym == 0.0_rt && ayp == 0.0_rt) && | ||
| (azm == 0.0_rt && azp == 0.0_rt))) { |
Check notice
Code scanning / CodeQL
Complex condition
asalmgren
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #3087. There are cases with 5 faces covered and one face still open. These cells should be marked small cells before the multi-cut check.