Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP Memory Advise : Set managed memory to coarse grain #2835

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

WeiqunZhang
Copy link
Member

For unsafe atomics to work on managed memory, we must set it to coarse
grain.

For gfx90a, we can explicitly use unsafeAtomicAdd.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

For unsafe atomics to work on managed memory, we must set it to coarse
grain.

For gfx90a, we can explicitly use unsafeAtomicAdd.
@WeiqunZhang WeiqunZhang merged commit 204bd7c into AMReX-Codes:development Jun 14, 2022
@WeiqunZhang WeiqunZhang deleted the unsafe_atomicadd branch June 14, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants