Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid M_PI because it's not in the C++ standard #2807

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Avoid M_PI because it's not in the C++ standard #2807

merged 1 commit into from
Jun 2, 2022

Conversation

WeiqunZhang
Copy link
Member

@WeiqunZhang WeiqunZhang commented Jun 2, 2022 •
edited by ax3l
Loading

Summary

Additional background

Replaces #2794

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang requested review from atmyers and jmsexton03 June 2, 2022 00:47
@WeiqunZhang
Copy link
Member Author

See also #2794.

@WeiqunZhang WeiqunZhang merged commit 45e3042 into AMReX-Codes:development Jun 2, 2022
@WeiqunZhang WeiqunZhang deleted the fix_m_pi branch June 2, 2022 19:12
@ax3l
Copy link
Member

ax3l commented Jun 6, 2022

Oh, I thought you planned to add an AMReX_Constants.H file that contains this, instead of copying it around @WeiqunZhang :)

ax3l added a commit to regro-cf-autotick-bot/warpx-feedstock that referenced this pull request Jun 6, 2022
@ax3l
Work-Around AMReX M_PI
0dd1b0a 
X-ref:
- AMReX-Codes/amrex#2807
- AMReX-Codes/amrex#2794
ax3l added a commit to regro-cf-autotick-bot/warpx-feedstock that referenced this pull request Jun 6, 2022
@ax3l
Work-Around AMReX M_PI
d0f4c03 
X-ref:
- AMReX-Codes/amrex#2807
- AMReX-Codes/amrex#2794
ax3l added a commit to regro-cf-autotick-bot/warpx-feedstock that referenced this pull request Jun 8, 2022
@ax3l
Work-Around AMReX M_PI
8fae8b6 
X-ref:
- AMReX-Codes/amrex#2807
- AMReX-Codes/amrex#2794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

@jmsexton03 jmsexton03 Awaiting requested review from jmsexton03

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WeiqunZhang @ax3l @atmyers