Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return non-zero if nans were found when using fnan #2704

Merged
merged 1 commit into from
Apr 9, 2022
Merged

Return non-zero if nans were found when using fnan #2704

merged 1 commit into from
Apr 9, 2022

Conversation

jrood-nrel
Copy link
Contributor

Summary

I'm not offended if anybody wants to close this and write it in any better way, but fnan should report non-zero if it finds nans.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang merged commit d70f70e into AMReX-Codes:development Apr 9, 2022
@jrood-nrel jrood-nrel deleted the jrood/fnan-error-code branch April 11, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrood-nrel @WeiqunZhang