Minor update to Docs on Linear solver curvilinear coordinate #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
reviewed
Mar 31, 2022
| @@ -388,14 +388,22 @@ to the ghost cell center; :cpp:`maxorder = 3` uses the boundary value and the fi | |||
| Curvilinear Coordinates | |||
| ======================= | |||
|
|
|||
| The linear solvers support curvilinear coordinates including 1D | |||
There was a problem hiding this comment.
The nodal solver supports RZ too, at least partially. It does require the user to rescale the problem. But the solver itself also has to do some additional correction. (git grep is_rz Src/LinearSolvers/MLMG)
There was a problem hiding this comment.
This is what I was trying to say in the next paragraph, but obviously, I was not clear. I'll try again...
There was a problem hiding this comment.
@WeiqunZhang Can you clarify if setMetricTerm(false) actually turns off the correction terms for the nodal solver or not. As I read the code, it appears to me as though that doesn't affect the nodal solver, and instead setRZCorrection(false) must be used.
WeiqunZhang
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support.
Summary
Additional background
Checklist
The proposed changes: