Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CUDA in CMakeList.txt for Spack smoke test. #2581

Merged
merged 1 commit into from
Jan 18, 2022

Conversation

etpalmer63
Copy link
Contributor

Summary

Adds the necessary lines to CMakeLists.txt to enable CMake to compile the Spack smoke test with CUDA.

Additional background

Tested on spack/develop. Passed, but requires an extra step to make sure the CUDA compilers match. Next step is to adjust the smoke test script for AMReX in Spack.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Copy link
Contributor

@sayerhs sayerhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look fine. Would it be possible to link the spack script to this PR for future reference? In particular, it would be nice to see what arguments are passed to CMake via spack.

@WeiqunZhang
Copy link
Member

https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/amrex/package.py

@WeiqunZhang WeiqunZhang merged commit 07267a0 into AMReX-Codes:development Jan 18, 2022
@etpalmer63 etpalmer63 deleted the CudaForSpackTest branch January 18, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants