Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP: Add -munsafe-fp-atomics to CMake #2577

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 12, 2022

Summary

Otherwise atomicAdd is much slower. Same as already done in GNU Make #2567

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

Otherwise atomicAdd is much slower. Same as already done in GNU Make.
@WeiqunZhang WeiqunZhang merged commit e34f5c6 into AMReX-Codes:development Jan 12, 2022
@ax3l ax3l deleted the cmake-hip_unsafe_fp branch January 13, 2022 00:20
@ax3l
Copy link
Member Author

ax3l commented Jan 13, 2022

Hm, I see:

clang-12: error: unknown argument: '-munsafe-fp-atomics'

in HiPACE++ now: Hi-PACE/hipace#644

@ax3l ax3l mentioned this pull request Jan 13, 2022
9 tasks
@ax3l
Copy link
Member Author

ax3l commented Jan 13, 2022

Ah, we still used HIP 4.1 in CI: Hi-PACE/hipace#645

@ax3l ax3l mentioned this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants