Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HIP CI #2502

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Fix HIP CI #2502

merged 2 commits into from
Nov 29, 2021

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Nov 29, 2021 •
edited
Loading

It's not correctly being passed the "-std=c++17" flag.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang
Copy link
Member

I think we should add -std=c++17 to CXXFLAGS.

env: {CXXFLAGS: "-std=c++17 ...

@atmyers
Copy link
Member Author

atmyers commented Nov 29, 2021

I think I prefer this fix as its consistent with the other HIP test. It looks like it works now, with the -std=c++17 being passed correctly.

@WeiqunZhang WeiqunZhang mentioned this pull request Nov 29, 2021
Merged
5 tasks
@atmyers atmyers merged commit d62f0d2 into AMReX-Codes:development Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang