-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPCPP: AMREX_INTEL_ARCH #2459
DPCPP: AMREX_INTEL_ARCH #2459
Conversation
799d54d
to
677a8fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, just the manual docs are missing.
We could as a follow-up also implement a logic to try to find the local architecture as a heuristic, if that is potentially of any help?
set(AMReX_INTEL_ARCH_DEFAULT "$ENV{AMREX_INTEL_ARCH}") | ||
endif() | ||
|
||
set(AMReX_INTEL_ARCH ${AMReX_INTEL_ARCH_DEFAULT} CACHE STRING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document AMReX_INTEL_ARCH
in Docs/sphinx_documentation/source/GPU.rst
, so users find it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do it.
When AOT is on, set the target to AMREX_INTEL_ARCH, which is required if the SYCL backend is used and AOT is on.
677a8fe
to
90a5293
Compare
Sorry for the delay on looking this over. It got buried in my inbox by GitHub spam. |
When AOT is on, set the target to AMREX_INTEL_ARCH, which is required if the
SYCL backend is used and AOT is on.
Checklist
The proposed changes: