Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPCPP: AMREX_INTEL_ARCH #2459

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Conversation

WeiqunZhang
Copy link
Member

When AOT is on, set the target to AMREX_INTEL_ARCH, which is required if the
SYCL backend is used and AOT is on.

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@WeiqunZhang WeiqunZhang requested review from ax3l and sayerhs November 3, 2021 21:04
@WeiqunZhang WeiqunZhang force-pushed the dpcpp_aot branch 2 times, most recently from 799d54d to 677a8fe Compare November 6, 2021 22:22
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, just the manual docs are missing.

We could as a follow-up also implement a logic to try to find the local architecture as a heuristic, if that is potentially of any help?

Tools/CMake/AMReXOptions.cmake Show resolved Hide resolved
set(AMReX_INTEL_ARCH_DEFAULT "$ENV{AMREX_INTEL_ARCH}")
endif()

set(AMReX_INTEL_ARCH ${AMReX_INTEL_ARCH_DEFAULT} CACHE STRING
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document AMReX_INTEL_ARCH in Docs/sphinx_documentation/source/GPU.rst, so users find it :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it.

When AOT is on, set the target to AMREX_INTEL_ARCH, which is required if the
SYCL backend is used and AOT is on.
Docs/sphinx_documentation/source/GPU.rst Outdated Show resolved Hide resolved
Docs/sphinx_documentation/source/GPU.rst Outdated Show resolved Hide resolved
@etpalmer63
Copy link
Contributor

Sorry for the delay on looking this over. It got buried in my inbox by GitHub spam.

@ax3l ax3l merged commit 3a7a24d into AMReX-Codes:development Dec 8, 2021
@ax3l ax3l self-assigned this Dec 8, 2021
@WeiqunZhang WeiqunZhang deleted the dpcpp_aot branch December 9, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants