Skip to content

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jun 15, 2021

Summary

Bump HIP requirements to C++17 or newer (like DPC++).
At the moment, we only test against AMD's clang++/hipcc, which supports C++17 anyway.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@ax3l ax3l added the GPU label Jun 15, 2021
@ax3l ax3l requested a review from WeiqunZhang June 15, 2021 21:46
@ax3l
Copy link
Member Author

ax3l commented Jun 15, 2021

As of comment #2104 (comment) we might not want to do this yet.

Although it simplifies #2031 due to the linked bug above (or we wait for ROCm 4.4 to carve out this issue or fixate the build to C+14 only in the meantime).

Bump HIP requirements to C++17 or newer (like DPC++).
At the moment, we only test against AMD's clang++/hipcc, which
supports C++17 anyway.
@ax3l ax3l force-pushed the topic-hipCXX17 branch from 1fded9d to 0ef0a85 Compare June 15, 2021 21:48
@WeiqunZhang WeiqunZhang merged commit baf0d4c into AMReX-Codes:development Jun 15, 2021
@ax3l ax3l deleted the topic-hipCXX17 branch June 21, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants