Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize fextract allowing to specify coords perpendicular to slicedir #2035

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Generalize fextract allowing to specify coords perpendicular to slicedir #2035

merged 2 commits into from
Jun 1, 2021

Conversation

drummerdoc
Copy link
Member

Generalize fextract. Allow spec as coordinate + dir, so that 1D slice can be positioned as desired, within constraints of backward compatibility.

Summary

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@drummerdoc drummerdoc requested a review from ajnonaka May 18, 2021 23:55
@WeiqunZhang WeiqunZhang merged commit 70922cb into AMReX-Codes:development Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

@ajnonaka ajnonaka Awaiting requested review from ajnonaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drummerdoc @WeiqunZhang