Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs and trailing white spaces #1860

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

ccse
Copy link
Contributor

@ccse ccse commented Mar 13, 2021

The changes are purely white spaces only. git diff -w development..HEAD
shows nothing. It was done with

find . -type d \( -name .git \
                  -o -path ./paper \
               \) -prune -o \
       -type f \( -name "*.H" -o -name "*.h" -o -name "*.hh" -o -name "*.hpp" \
                  -o -name "*.c" -o -name "*.cc" -o -name "*.cpp" -o -name "*.cxx" \
                  -o -name "*.f" -o -name "*.F" -o -name "*.f90" -o -name "*.F90" \
                  -o -name "*.py" \
                  -o -name "*.md" -o -name "*.rst" \
                  -o -name "*.sh" \
                  -o -name "*.tex" \
                  -o -name "*.txt" \
               \) \
    -exec grep -Iq . {} \; \
    -exec sed -i 's/[[:blank:]]\+$//g' {} + \
    -exec sed -i 's/\t/\ \ \ \ \ \ \ \ /g' {} +

We will add a CI check as a follow-up.

@WeiqunZhang WeiqunZhang requested a review from atmyers March 13, 2021 02:05
The changes are purely white spaces only. `git diff -w development..HEAD`
shows nothing.  It was done with

```
find . -type d \( -name .git \
                  -o -path ./paper \
               \) -prune -o \
       -type f \( -name "*.H" -o -name "*.h" -o -name "*.hh" -o -name "*.hpp" \
                  -o -name "*.c" -o -name "*.cc" -o -name "*.cpp" -o -name "*.cxx" \
                  -o -name "*.f" -o -name "*.F" -o -name "*.f90" -o -name "*.F90" \
                  -o -name "*.py" \
                  -o -name "*.md" -o -name "*.rst" \
                  -o -name "*.sh" \
                  -o -name "*.tex" \
                  -o -name "*.txt" \
               \) \
    -exec grep -Iq . {} \; \
    -exec sed -i 's/[[:blank:]]\+$//g' {} + \
    -exec sed -i 's/\t/\ \ \ \ \ \ \ \ /g' {} +
```

We will add a CI check as a follow-up.
@atmyers
Copy link
Member

atmyers commented Mar 14, 2021

After this is merged, we should add a style guide with things like this, space before ( after function names, etc...

@WeiqunZhang WeiqunZhang merged commit 486cd43 into AMReX-Codes:development Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants