Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum C++ standard from 11 to 14. #1787

Merged
merged 15 commits into from
Feb 16, 2021
Merged

Bump minimum C++ standard from 11 to 14. #1787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
701087d
Bump the minimum C++ std to 14.
atmyers Feb 11, 2021
aa2bbdd
gcc-5.5 -> gcc-5
atmyers Feb 11, 2021
e310015
gcc-5.5 -> gcc-5, but for real
atmyers Feb 11, 2021
97dfbb9
just use gcc 6
atmyers Feb 11, 2021
303d638
maybe 7 works, who knows
atmyers Feb 11, 2021
3bb4bd1
try cuda 9.2
atmyers Feb 11, 2021
2ff5de2
change repo
atmyers Feb 11, 2021
0b4de97
remove unneeded packages
atmyers Feb 11, 2021
04d2374
gcc version back to 6
atmyers Feb 11, 2021
f2fb475
add cuda path
atmyers Feb 11, 2021
bccd2aa
need curand
atmyers Feb 11, 2021
07d8bb6
need curand dev
atmyers Feb 11, 2021
544ae65
only set -std=c++14 for gcc 5, otherwise use the default
atmyers Feb 16, 2021
20c4f59
also for hpcsdk
atmyers Feb 16, 2021
fe93f94
Merge branch 'development' into bump_standard
atmyers Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
need curand dev
  • Loading branch information
@atmyers
atmyers committed Feb 11, 2021
commit 07d8bb6719b6f4478b1596c6af4d2d0fa4551a49
2 changes: 1 addition & 1 deletion .github/workflows/dependencies/dependencies_nvcc9.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ sudo apt-get install -y \
cuda-minimal-build-9-2 \
cuda-nvml-dev-9-2 \
cuda-nvtx-9-2 \
cuda-curand-9.2
cuda-curand-dev-9.2

sudo ln -s cuda-9.2 /usr/local/cuda

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,11 +187,11 @@ jobs:
which nvcc || echo "nvcc not in PATH!"
mkdir build
cd build
cmake .. \
-DCMAKE_VERBOSE_MAKEFILE=ON \
-DAMReX_BUILD_TUTORIALS=ON \
-DAMReX_PARTICLES=ON \
-DAMReX_GPU_BACKEND=CUDA \
cmake .. \
-DCMAKE_VERBOSE_MAKEFILE=ON \
-DAMReX_BUILD_TUTORIALS=ON \
-DAMReX_PARTICLES=ON \
-DAMReX_GPU_BACKEND=CUDA \
-DCMAKE_C_COMPILER=$(which gcc-6) \
-DCMAKE_CXX_COMPILER=$(which g++-6) \
-DCMAKE_CUDA_HOST_COMPILER=$(which g++-6) \
Expand Down