Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Github action that tries to build tutorials with SP particles and DP mesh. #1764

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Add a Github action that tries to build tutorials with SP particles and DP mesh. #1764

merged 3 commits into from
Jan 30, 2021

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jan 29, 2021

Currently this combination is only caught by the Nyx CI.

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • are described in the proposed changes to the AMReX documentation, if appropriate

@atmyers atmyers requested a review from WeiqunZhang January 29, 2021 21:35
@WeiqunZhang WeiqunZhang merged commit 466e307 into AMReX-Codes:development Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang